Styles for the cookie debugger, replacing the old tool's cookie table - #37
Merged
Merged
Conversation
For phpbb/phpbb-website-private#227 (paul999/phpbb-website-private#27), which rebuilds the support team's cookie debugger at /support/cookies/ and kept its styles inline until now: - .verdict-good, .verdict-bad and .verdict-neutral colour a cookie setting by whether it works for the board. - dl.cookie-summary lays out domain, path and secure flag with their reasons. - td.long, td.marker and td.nowrap keep long cookie values and markers from widening the tables. - details summary gets its disclosure triangle back, which prosilver's reset hides. The old tool's table.cookie, th.cookie and td.cookie go: phpbb/website#230 removes the only page that used them. website.css?5 in index.css makes browsers fetch the new rules. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
There was a problem hiding this comment.
🟢 Approval recommended
The changes are narrowly-scoped CSS updates with consistent cache-busting and no remaining in-repo references to the removed legacy selectors.
Pull request overview
Moves styling for the support-team cookie debugger (/support/cookies/) into the shared website asset stylesheet and removes legacy styling for the old cookie table, keeping asset cache-busting consistent.
Changes:
- Replaces legacy
table.cookie/th.cookie/td.cookiestyling with new.cookie-debugger-scoped rules incss/website.css. - Adds cookie-debugger-specific layout/formatting rules (verdict colors, summary
dl, long table cell wrapping,details summarymarker restoration). - Bumps the cache-busting token for
website.cssincss/index.cssfrom?4to?5.
File summaries
| File | Description |
|---|---|
| css/website.css | Removes old cookie-table rules and adds .cookie-debugger-scoped styles for the rebuilt support cookie debugger UI. |
| css/index.css | Updates the website.css import query token to ensure browsers fetch the updated stylesheet. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Styles for the support team's cookie debugger, which phpbb/phpbb-website-private#227 rebuilds at
/support/cookies/(paul999/phpbb-website-private#27). Until now its styles sat inline in the page, and review asked for them to live here.What's in it
.cookie-debuggerrules inwebsite.css:.verdict-good,.verdict-badand.verdict-neutralcolour each cookie setting by whether it works for the board.dl.cookie-summarylays out domain, path and secure flag with the reason for each.td.long,td.markerandtd.nowrapstop long cookie values and markers from widening the tables.details summarygets back the disclosure triangle that prosilver's reset hides.table.cookie,th.cookieandtd.cookierules go. phpbb/website#230 removes the only page that used them.index.cssnow importswebsite.css?5, so browsers fetch the new rules.After merging
Run
composer update phpbb/website-assetsin both phpbb/phpbb-website-private#227 and phpbb/website#230, and deploy them together..htdevserves/assets/from the old site's copy first, so updating only the Symfony side would leave the page unstyled. #227 also bumpsassets_versioninbase.html.twig, so cached copies ofindex.cssget refreshed.🤖 Generated with Claude Code