Styles for the knowledge base article page - #36
Conversation
For phpbb/phpbb-website-private#21: the article's header (title, lead description, author line, version and category tags, a notice for articles only the team and author see) and its footer panel (attachments with their size, the support-topic link field and its Copy button). markdown-editor.css: Markdown headings no longer inherit prosilver's uppercase h3, so an author's heading keeps the case it was written in. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
There was a problem hiding this comment.
🟡 Changes recommended
Several new KB selectors are likely overridden by existing #main defaults (and Markdown h3 by #main .panel h3), so intended styles may not apply reliably without specificity adjustments.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Adds styling for the Knowledge Base (KB) article page within the support docs section, and adjusts rendered Markdown heading casing to prevent unintended uppercase transforms from site-wide styling.
Changes:
- Introduces
.kb-article*styles for the KB article header/meta/tags, status notice, and footer (attachments + BBCode copy field). - Updates rendered Markdown heading styles so authored casing is preserved (not transformed to uppercase) where
.markdown-bodyis used.
File summaries
| File | Description |
|---|---|
| css/support_docs.css | Adds KB article page layout/styling for header/meta/tags, status notice, and footer panel UI. |
| css/markdown-editor.css | Updates Markdown heading rendering to preserve original text casing. |
Review details
Suppressed comments (6)
css/support_docs.css:1253
- Same specificity issue as the description:
#main pin website.css will override.kb-article p.kb-article-metafor alignment/sizing. Add a#main-scoped selector so this meta line reliably renders left-aligned with the intended font size.
.kb-article p.kb-article-meta {
margin: 0 0 8px;
color: #626D76;
font-size: 1.1em;
text-align: left;
}
css/support_docs.css:1262
#main ulin website.css sets list indentation and font sizing with ID specificity, so this reset (margin: 0; padding: 0; list-style: none;) may not apply on the article page. Prefixing with#main(like other KB rules in this file) ensures the tag list renders unindented.
.kb-article-tags {
display: flex;
flex-wrap: wrap;
gap: 6px;
list-style: none;
margin: 0;
padding: 0;
}
css/support_docs.css:1284
#main aappliestext-decoration: underlinewith higher specificity than.kb-article-tags a, so the non-underlined tag links may not work inside#main. Add a#main-scoped selector so the base link style can override the global rule.
.kb-article-tags a {
color: #105289;
text-decoration: none;
}
css/support_docs.css:1289
- Once the base tag-link rule is made
#main-specific, the hover/focus rule also needs#mainspecificity; otherwise the base#main ... { text-decoration: none; }will win and links may never underline on hover/focus.
.kb-article-tags a:hover,
.kb-article-tags a:focus {
text-decoration: underline;
}
css/support_docs.css:1333
#main uladds a left margin with ID specificity, so this attachment list may still render indented even withmargin: 0; padding: 0;. Consider adding a#main-scoped selector to ensure the list reset wins.
.kb-article-attachments ul {
list-style: none;
margin: 0;
padding: 0;
}
css/support_docs.css:1296
- This status notice is also a
pand will be affected by#main pdefaults (notablytext-align: justify) unless you add a#main-scoped selector, similar to#main .kb-articles pearlier in this stylesheet.
.kb-article p.kb-article-status {
margin: 4px 0 8px;
padding: 8px 12px;
border: 1px solid #E5C07B;
border-radius: 5px;
- Files reviewed: 2/2 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| /* prosilver writes its own h3 in capitals; an author's heading keeps | ||
| the case it was written in. */ | ||
| text-transform: none; | ||
| } |
| .kb-article p.kb-article-description { | ||
| margin: 0 0 6px; | ||
| color: #333333; | ||
| font-size: 1.3em; | ||
| text-align: left; | ||
| } |
Styles for the knowledge base article page moving to the website (phpbb/phpbb-website-private#21, branch
issue-21/kb-article).css/support_docs.css: the article page.kb-article*. No other page uses these classes.css/markdown-editor.cssMarkdown headings get
text-transform: none. Otherwise prosilver's globalh3rule writes an author's### Basicsas "BASICS". Only the KB article and the Markdown demo render.markdown-bodytoday.Checked
After this merges,
composer update phpbb/website-assetsgoes into the #21 branch.🤖 Generated with Claude Code