Reject links entered as contribution names or permalinks - #458
Open
ECYaz wants to merge 1 commit into
Open
Conversation
A link pasted into the permalink field was rejected, but the error message suggested the slugified link back as a valid example, and pasting that suggestion in is accepted. A link entered as the contribution name with the permalink left blank produced the same garbage permalink silently. Both mistakes gave the contribution a permanent link shaped address only moderators can fix, which is how the ColoredLight permalink in phpbb#394 came to be. Reject values shaped like a link in the name and permalink fields with a clear message instead. Existing contributions with such a name or permalink still pass validation untouched, so they are not locked out of their manage page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reject link shaped values in the name and permalink fields with a clear message, for authors and moderators alike.
Fixes #394