Skip to content

Use explicit union types for nullable declarations - #36

Merged
iMattPro merged 4 commits into
developfrom
copilot/fix-extension-tests-php-82
Nov 5, 2026
Merged

iMattPro merged 4 commits into
developfrom
copilot/fix-extension-tests-php-82

Conversation

Copilot AI commented Nov 5, 2026 •

Copy link
Copy Markdown

The PHP 8.2 “none” job fails PHPCS because it rejects nullable shortcut syntax. Six declarations now use explicit union types.

  • Changes: Replaced ?int, ?cache, and ?array with int|null, cache|null, and array|null.
protected function match_prefix(string $title, array $tags): array|null
  • Compatibility note: Native union types require PHP 8, while composer.json still declares PHP >=7.2.

Co-authored-by: iMattPro <303711+iMattPro@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix failing GitHub Actions job for PHP 8.2 Use explicit union types for nullable declarations Nov 5, 2026
Copilot AI requested a review from iMattPro November 5, 2026 19:54
@iMattPro
iMattPro marked this pull request as ready for review November 5, 2026 19:55

@iMattPro iMattPro left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is against the wrong branch. The failing tests you are fixing is on the develop branch.

Copilot AI commented Nov 5, 2026

Copy link
Copy Markdown
Author

This PR is against the wrong branch. The failing tests you are fixing is on the develop branch.

Confirmed: PR #36 currently targets master, while the failing run was triggered on develop. This needs a base-branch change to develop, not a code change. I don’t have a PR-base update operation available here, so please change the PR’s base branch to develop.

Co-authored-by: iMattPro <303711+iMattPro@users.noreply.github.com>
Co-authored-by: iMattPro <303711+iMattPro@users.noreply.github.com>
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.81%. Comparing base (f00fa7e) to head (59fc057).
⚠️ Report is 31 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop      #36      +/-   ##
=============================================
+ Coverage      98.71%   98.81%   +0.09%     
+ Complexity       829      820       -9     
=============================================
  Files             20       20              
  Lines           2885     3029     +144     
=============================================
+ Hits            2848     2993     +145     
+ Misses            37       36       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@iMattPro
iMattPro merged commit acbfac6 into develop Nov 5, 2026
58 of 60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants