Redesign Topic Prefixes into Tagging system by iMattPro · Pull Request #35 · phpbb-extensions/topicprefixes

iMattPro · 2026-09-20T13:38:04Z

Updates the topic title prefixing into a full fledges topic tagging system with filtering/search and prettier badges.

Will require this PR: phpbb/phpbb#7052 - adds events that will allow the tags to appear in most places where topics appear (such as in UCP and MCP panels).

ACP panel

Posting panel:

Viewing forum:

Viewing topic:

Closes #17
Closes #18

codecov-commenter · 2026-09-20T14:15:11Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (eba4b2d) to head (362dc14).

Additional details and impacted files

@@              Coverage Diff              @@
##             master       #35      +/-   ##
=============================================
+ Coverage     99.11%   100.00%   +0.88%     
- Complexity       83       260     +177     
=============================================
  Files             7        12       +5     
  Lines           225       930     +705     
=============================================
+ Hits            223       930     +707     
+ Misses            2         0       -2

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copilot

Copilot review overview

🟡 Changes recommended

A nonexistent phpBB lifecycle event leaves ACP-relocated topics without tags, and global-topic badges produce inaccessible no-op links.

Get a fresh assessment by requesting another Copilot review.

Review effort: Balanced
Findings: 1 · 1

Open (2)

Missing phpBB hook prevents tag copying during ACP post relocation · New
Avoid no-op filter links for global topics · New

What changed in this PR

Redesigns topic prefixes as relational, multi-tag metadata with filtering, colored badges, lifecycle handling, and legacy-data migration.

Changes:

Adds tag management, rendering, filtering, and phpBB event integrations.
Migrates legacy prefixes into normalized tag relationships.
Replaces legacy tests and UI with comprehensive tagging coverage.

File	Description
`tests/tags/renderer_test.php`	Tests badge rendering and filter URLs.
`tests/event/viewforum_listener_test.php`	Tests forum filtering and pagination.
`tests/event/posting_listener_test.php`	Tests posting and editing assignments.
`tests/event/listener_test.php`	Removes legacy listener tests.
`tests/event/lifecycle_listener_test.php`	Tests lifecycle tag preservation.
`tests/event/display_listener_test.php`	Tests tags across display surfaces.
`tests/dbal/tags_base.php`	Adds shared database test setup.
`tests/dbal/tag_manager_test.php`	Tests tag catalog and CRUD behavior.
`tests/dbal/simple_test.php`	Removes legacy schema test.
`tests/dbal/manager_update_prefix_test.php`	Removes legacy update tests.
`tests/dbal/manager_prepend_prefix_test.php`	Removes title-prefix tests.
`tests/dbal/manager_move_prefix_test.php`	Removes legacy ordering tests.
`tests/dbal/manager_get_prefixes_test.php`	Removes legacy retrieval tests.
`tests/dbal/manager_get_prefix_test.php`	Removes single-prefix tests.
`tests/dbal/manager_get_active_prefixes_test.php`	Removes active-prefix tests.
`tests/dbal/manager_delete_prefix_test.php`	Removes legacy deletion tests.
`tests/dbal/manager_base.php`	Removes legacy test base.
`tests/dbal/manager_add_prefix_test.php`	Removes legacy creation tests.
`tests/dbal/legacy_migration_test.php`	Tests legacy data conversion.
`tests/dbal/fixtures/topic_tags.xml`	Adds relational tag fixtures.
`tests/dbal/fixtures/topic_prefixes.xml`	Removes legacy fixtures.
`tests/dbal/filter_test.php`	Tests multi-tag filtering.
`tests/dbal/assignment_manager_test.php`	Tests assignment persistence and copying.
`tests/controller/move_prefix_test.php`	Removes legacy controller test.
`tests/controller/main_test.php`	Removes legacy routing test.
`tests/controller/edit_prefix_test.php`	Removes legacy editing test.
`tests/controller/display_settings_test.php`	Removes legacy display test.
`tests/controller/delete_prefix_test.php`	Removes legacy deletion test.
`tests/controller/admin_controller_test.php`	Tests new ACP tag controller.
`tests/controller/admin_controller_base.php`	Removes legacy controller fixture.
`tests/controller/add_prefix_test.php`	Removes legacy creation test.
`tests/acp/acp_module_test.php`	Updates namespaced ACP tests.
`tags/renderer.php`	Builds badges and filter URLs.
`tags/manager.php`	Manages tag definitions and availability.
`tags/filter.php`	Implements tag-aware SQL filtering.
`styles/all/theme/topic_tags.css`	Styles badges and controls.
`styles/all/template/topic_tag_badges.html`	Renders reusable tag badges.
`styles/all/template/event/viewtopic_topic_title_prepend.html`	Adds view-topic badges.
`styles/all/template/event/viewforum_body_topic_row_before.html`	Adds forum filter controls.
`styles/all/template/event/topiclist_row_prepend.html`	Adds topic-list badges.
`styles/all/template/event/search_results_topic_title_prepend.html`	Adds post-search badges.
`styles/all/template/event/posting_editor_subject_before.html`	Adds tag checkboxes.
`styles/all/template/event/overall_header_head_append.html`	Loads frontend tag styles.
`styles/all/template/event/mcp_forum_topic_title_before.html`	Adds MCP badges.
`README.md`	Documents the tagging system.
`prefixes/nestedset_prefixes.php`	Removes nested-set implementation.
`prefixes/manager.php`	Removes legacy prefix manager.
`prefixes/manager_interface.php`	Removes legacy manager interface.
`migrations/v200_schema.php`	Adds relational tagging schema.
`migrations/v200_data.php`	Migrates legacy prefix data.
`migrations/v200_cleanup.php`	Removes obsolete columns.
`language/en/topic_prefixes.php`	Adds frontend tag messages.
`language/en/info_acp_topic_prefixes.php`	Updates ACP metadata and logs.
`language/en/acp_topic_prefixes.php`	Adds ACP tag language.
`ext.php`	Raises runtime requirements.
`event/viewforum_listener.php`	Integrates filters and forum badges.
`event/posting_listener.php`	Validates and saves assignments.
`event/listener.php`	Removes legacy listener.
`event/lifecycle_listener.php`	Handles topic lifecycle operations.
`event/display_listener.php`	Integrates non-forum displays.
`config/tables.yml`	Registers relationship tables.
`config/services.yml`	Registers tag services and listeners.
`composer.json`	Declares version 2 requirements.
`CHANGELOG.md`	Documents the 2.0 redesign.
`adm/style/acp_topic_prefixes.js`	Removes obsolete forum switching.
`adm/style/acp_topic_prefixes.html`	Rebuilds the ACP interface.
`adm/style/acp_topic_prefixes.css`	Styles ACP badges and controls.
`acp/topic_prefixes_module.php`	Updates the ACP page title.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Copilot

Copilot review overview

🔵 Needs a closer look

Disabled assigned tags are incorrectly exposed as available forum filter choices.

Review effort: Balanced
Findings: None

Resolved since last review (2)

Missing phpBB hook prevents tag copying during ACP post relocation
Avoid no-op filter links for global topics

Previously missed (1)

In code that hasn't changed since last review

Prevent disabled tags from appearing as filter choices

event/viewforum_listener.php:125

Disabled tags become visible as filter choices whenever they remain assigned to a moved/global topic. This bypasses the enabled-only filtering above; the later loop already restores a disabled tag when it is actually selected, so only enabled unavailable tags should be added here.

rxu

Couldn't really test the functionality due to phpBB 3.3.18 requirement (new events are pending to be merged probably).

rxu · 2026-09-23T06:03:21Z

Tested it on 3.3.17 a bit.
Updating from Topic tags v.1 worked fine.
Creating, copying, merging topics worked fine.
Filtering by tag worked fine.

When you create a topic f.e. with tags One and Two, then you disable tag Two, the tag disappears from the filters, but is still displayed beside the topic title. Then, when you click it beside the topic title, it gets back again to the filters list together with topics filtering process. Not sure what should be the correct behavior, but probably if you disable a tag while already there're existing topics with such a tag, it shouldn't be removed from filters list (because it's still appears becide topic titles and works for filtering anyway).

2026-09-23.130438.mp4

iMattPro · 2026-09-23T12:41:07Z

That is the intended behavior. When disabled you can't assign it any more and it's not part of the filter list by default. But existing topic assignments remain visible. If you click on it then it only appears in the filter list because it's currently being used as a filter and so you can unclick it to stop filtering with it. So it only appears in the filter list if it's being used as a filter otherwise it won't be shown.

In other words when disabled it's removed from assigning and filter panel by default. But when interacting with topics that already have it, it appears so you can unassign it or filter/unfilter with it. This is also true for the behavior when a topic is moved to a forum where the tag is not assigned to - you can still see it and unassign or filter/unfilter them.

Since they will leave the search results

iMattPro added 9 commits September 19, 2026 13:48

Initial total redesign from title prefixes to topic tags

0520fd5

Updates and tweaky fixes and more tests

ce0dd54

Add UCP listeners assuming we get these events in the core

e47df67

Ensure topic tags stay with a topic after being moved to other forums

3a78f49

Add orphan handling

a1398e0

Fix CSS issues

6f716ef

Fix tests

393ffe0

Fix dates

5b05fc9

Refactor functional tests

caf3bb7

Performance improvements pass

d94fd00

iMattPro requested a balanced review from Copilot September 20, 2026 16:45

Copilot started reviewing on behalf of iMattPro September 20, 2026 16:45 View session

Copilot AI reviewed Sep 20, 2026

View reviewed changes

Comment thread event/lifecycle_listener.php Outdated

Comment thread styles/all/template/topic_tag_badges.html

iMattPro added 4 commits September 20, 2026 11:36

Revert handling of tags when all users posts moved to a new forum

797ba46

CSS improvements

ded6748

Avoid no-op filter links for global topics

db7c63c

Small code fixes and improvements

3c4ef93

iMattPro requested a review from rxu September 20, 2026 21:00

iMattPro added 2 commits September 20, 2026 14:12

Fix tests

bac6367

Styling fixes in the ACP

1f8a7ee

iMattPro requested a balanced review from Copilot September 20, 2026 22:34

Copilot started reviewing on behalf of iMattPro September 20, 2026 22:35 View session

Copilot AI reviewed Sep 20, 2026

View reviewed changes

iMattPro added 3 commits September 20, 2026 16:41

Prevent disabled tags from appearing as filter choices

a3f5ea3

Add subtle depth effect to tags so they’r enot so flat

30280e6

Add tooltips to tags

d4dc4c1

rxu reviewed Sep 21, 2026

View reviewed changes

Comment thread migrations/v200_data.php

Comment thread migrations/v200_data.php Outdated

Comment thread migrations/v200_data.php

Comment thread migrations/v200_data.php Outdated

iMattPro added 2 commits September 21, 2026 07:03

Added multibyte prefix test coverage using Japanese text

e0a8c32

Fix MSSQL - as usual

3983d76

iMattPro added 5 commits September 21, 2026 15:46

Handling for 4-byte emojis

ce9955d

Enforce a 50 char limit for topic prefix/tags

215f7e0

Make all three stateless text utilities static

f713670

Rename to Topic Tags

d9e7d99

Loosen phpBB version requirements and add notes about

d20a8c6

Default panel shows only enabled tags available in forum

857b2d8

iMattPro force-pushed the redesign branch from 7880bf4 to a7c0722 Compare September 23, 2026 15:28

Implement lightweight retained-tag tooltip

cb6242f

iMattPro force-pushed the redesign branch from a7c0722 to cb6242f Compare September 23, 2026 21:05

Adjust topic tags in search profile

16c8785

iMattPro force-pushed the redesign branch from 6eacf16 to 410a2cf Compare September 24, 2026 16:27

Mark version as “dev” for now [ci skip]

2980294

iMattPro force-pushed the redesign branch from 410a2cf to 2980294 Compare September 24, 2026 23:47

iMattPro added 2 commits September 24, 2026 18:24

Migrate stored for last post subject titles

43253cc

Disable tag filtering in search results

362dc14

Since they will leave the search results

Navigation Menu

Redesign Topic Prefixes into Tagging system - #35

Redesign Topic Prefixes into Tagging system#35
iMattPro wants to merge 32 commits into
phpbb-extensions:masterfrom
iMattPro:redesign

iMattPro commented Sep 20, 2026 •

edited

Loading

Uh oh!

codecov-commenter commented Sep 20, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

rxu left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rxu commented Sep 23, 2026 •

edited

Loading

Uh oh!

iMattPro commented Sep 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

iMattPro commented Sep 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov-commenter commented Sep 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🔵 Needs a closer look

Uh oh!

rxu left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rxu commented Sep 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

iMattPro commented Sep 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

iMattPro commented Sep 20, 2026 •

edited

Loading

codecov-commenter commented Sep 20, 2026 •

edited

Loading

rxu commented Sep 23, 2026 •

edited

Loading