Skip to content

Refactor entities and operators - #382

Merged
iMattPro merged 1 commit into
phpbb-extensions:developfrom
iMattPro:dev/4.0-refactor-entities
Sep 24, 2026
Merged

iMattPro merged 1 commit into
phpbb-extensions:developfrom
iMattPro:dev/4.0-refactor-entities

Conversation

@iMattPro

Copy link
Copy Markdown
Contributor

No description provided.

Keep hydration side-effect free so stored values are not transformed as new input. Use explicit factories and update only dirty fields.

BREAKING CHANGE: Rule entities no longer expose load(), insert(), or save(). Their non-shared service IDs were also removed. Use operator create, get, add, and save methods instead.

Refinements to refactoring
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.73%. Comparing base (99f89d5) to head (3428dbe).

Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #382      +/-   ##
=============================================
- Coverage      99.48%   98.73%   -0.75%     
- Complexity       346      353       +7     
=============================================
  Files             16       17       +1     
  Lines           1169     1189      +20     
=============================================
+ Hits            1163     1174      +11     
- Misses             6       15       +9     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@iMattPro
iMattPro merged commit b32784b into phpbb-extensions:develop Sep 24, 2026
29 checks passed
@iMattPro
iMattPro deleted the dev/4.0-refactor-entities branch September 24, 2026 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants