Skip to content

Shutdown already started modules when a later module init fails - #25157

Open
dunglas wants to merge 1 commit into
php:PHP-8.4from
dunglas:rinit-bailout-rshutdown
Open

dunglas wants to merge 1 commit into
php:PHP-8.4from
dunglas:rinit-bailout-rshutdown

Conversation

@dunglas

@dunglas dunglas commented Nov 2, 2026 •

Copy link
Copy Markdown
Member

This prevents issues such as session files never closed with session.auto_start=1.

Patch written with the assistance of Claude.

php_request_shutdown() only calls RSHUTDOWN once every RINIT returned,
so the modules activated before a failing one never released their
request state. With session.auto_start, the session stayed locked and
every later request for it blocked forever in persistent SAPIs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant