Repository navigation
Conversation
…released Pdo\Pgsql::setNoticeCallback() stores a request-allocated fcall cache on the driver handle. A persistent handle outlives the request, so the next request on the same connection uses freed memory as soon as it receives a notice or sets a new callback. Drop the callback from the persistent_shutdown hook, which pdo_sqlite also uses for its user functions, once the last object of the request releases the handle.
devnexen
approved these changes
Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pdo\Pgsql::setNoticeCallback()keeps a request-allocated fcall cache on the driver handle, and nothing drops it when a persistent handle outlives the request, so the next request on that connection runs the freed callback as soon as it receives a notice. Thepersistent_shutdownhook now clears it once the last object of the request releases the handle (refcount <= 2, the checkpdo_dbh_free_storage()uses before rolling back). On PHP-8.6 and master a9138d7 already applies that check in the caller, so the merge there drops the guard and adds the cleanup to the existingpdo_pgsql_request_shutdown().