Skip to content

Fix GH-25112 Phar CGI redirect target #25117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kairosci wants to merge 2 commits into
base: PHP-8.6
Choose a base branch
from
Open

Fix GH-25112 Phar CGI redirect target #25117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c0d85a3
Fix GH-25112 Phar CGI redirect target
kairosci Nov 1, 2026
0fd6a34
Pass valid MIME types to Phar::webPhar test
kairosci Nov 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 4 additions & 17 deletions ext/phar/phar_object.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -557,7 +557,7 @@ PHP_METHOD(Phar, webPhar)
const char *basename;
size_t fname_len, index_php_len = 0;
size_t entry_len;
int code, not_cgi;
int code;
phar_archive_data *phar = NULL;
phar_entry_info *info = NULL;
size_t sapi_mod_name_len = strlen(sapi_module.name);
Expand Down Expand Up @@ -674,7 +674,6 @@ PHP_METHOD(Phar, webPhar)
pt = estrndup(testit, (pt - testit) + (fname_len - (basename - fname)));
efree(testit);
}
not_cgi = 0;
} else {
path_info = SG(request_info).request_uri;

Expand All @@ -689,7 +688,6 @@ PHP_METHOD(Phar, webPhar)
entry = estrndup(pt + (fname_len - (basename - fname)), entry_len);

pt = estrndup(path_info, (pt - path_info) + (fname_len - (basename - fname)));
not_cgi = 1;
}

if (ZEND_FCI_INITIALIZED(rewrite_fci)) {
Expand Down Expand Up @@ -758,29 +756,18 @@ PHP_METHOD(Phar, webPhar)
if (!phar || (info = phar_get_entry_info(phar, entry, entry_len, NULL, false)) == NULL) {
phar_do_404(phar, fname, fname_len, f404);
} else {
char *tmp = NULL, sa = '\0';
sapi_header_line ctr = {0};
ctr.response_code = 301;
ctr.line_len = sizeof("HTTP/1.1 301 Moved Permanently")-1;
ctr.line = "HTTP/1.1 301 Moved Permanently";
sapi_header_op(SAPI_HEADER_REPLACE, &ctr);

if (not_cgi) {
tmp = strstr(path_info, basename) + (fname_len - (basename - fname));
sa = *tmp;
*tmp = '\0';
}

ctr.response_code = 0;

if (path_info[strlen(path_info)-1] == '/') {
ctr.line_len = spprintf((char **) &(ctr.line), 4096, "Location: %s%s", path_info, entry + 1);
if (pt[strlen(pt)-1] == '/') {
ctr.line_len = spprintf((char **) &(ctr.line), 4096, "Location: %s%s", pt, entry + 1);
} else {
ctr.line_len = spprintf((char **) &(ctr.line), 4096, "Location: %s%s", path_info, entry);
}

if (not_cgi) {
*tmp = sa;
ctr.line_len = spprintf((char **) &(ctr.line), 4096, "Location: %s%s", pt, entry);
}

sapi_header_op(SAPI_HEADER_REPLACE, &ctr);
Expand Down
33 changes: 33 additions & 0 deletions ext/phar/tests/gh25112.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
--TEST--
GH-25112: Phar::webPhar() CGI redirect drops PATH_INFO after rewriting to the index
--CGI--
--EXTENSIONS--
phar
--INI--
phar.readonly=0
phar.require_hash=0
variables_order=EGPC
register_argc_argv=0
cgi.fix_pathinfo=0
--ENV--
REQUEST_METHOD=GET
REQUEST_URI=/sub/gh25112.phar/foo
SCRIPT_NAME=/sub/gh25112.phar
PATH_INFO=/foo
--FILE--
<?php
$fname = __DIR__ . '/gh25112.phar';
$phar = new Phar($fname);
$phar->addFromString('index.php', '<?php echo "ok\n"; ?>');
$phar->setStub('<?php
Phar::webPhar(null, null, null, [], function ($path) { return "/"; });
__HALT_COMPILER(); ?>');
unset($phar);
include $fname;
?>
--CLEAN--
<?php @unlink(__DIR__ . '/gh25112.phar'); ?>
--EXPECTHEADERS--
Status: 301 Moved Permanently
Location: /sub/gh25112.phar/index.php
--EXPECT--
Loading