Skip to content

zend_ast: Fix AST printing of interface extends list as implements - #25064

Closed
jorgsowa wants to merge 2 commits into
php:PHP-8.4from
jorgsowa:fix-ast-export-interface-extends
Closed

jorgsowa wants to merge 2 commits into
php:PHP-8.4from
jorgsowa:fix-ast-export-interface-extends

Conversation

@jorgsowa

Copy link
Copy Markdown
Contributor

Fixed AST printing of interface extends list as implements

@jorgsowa jorgsowa self-assigned this Oct 30, 2026
assert(false && function () {
interface I extends A, B {
}

@jorgsowa jorgsowa Oct 30, 2026 •

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is weird whitespace, but honestly I don't care so much about whitespaces. It's unrelated to the fix.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same whitespace problem occurs in many other places as well. It doesn't really matter a whole lot and is indeed unrelated.

Comment thread Zend/zend_ast.c Resolved
@jorgsowa
jorgsowa force-pushed the fix-ast-export-interface-extends branch from ea3d5e5 to 211c424 Compare November 4, 2026 16:31
@jorgsowa
jorgsowa requested a review from ndossche November 4, 2026 16:32
@jorgsowa jorgsowa closed this in b4fb1d7 Nov 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants