Repository navigation
Conversation
…files File/eval code take This from the existing frame's scope, so This may be a class instead of an object.
iliaal
approved these changes
Oct 30, 2026
iliaal
left a comment
iliaal
left a comment
Member
There was a problem hiding this comment.
LGTM. parent:: from an included file was broken the same way (tracing gave P:B P:A P:A for a P:B result) and this fixes it too, might be worth a second case in the test.
| scope_ref = ir_LOAD_A(jit_EX(This.value.ref)); | ||
| } else if (op_array->fn_flags & ZEND_ACC_CLOSURE) { | ||
| } else if ((op_array->fn_flags & ZEND_ACC_CLOSURE) || !op_array->function_name) { | ||
| /* Closured can be unbound, file/eval inherits This from the existing frame's scope. */ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
File/eval code take This from the existing frame's scope, so This may be a class instead of an object.
Found while implementing fast-path for static property access in JIT