Repository navigation
Conversation
Successful checkdnsrr() and dns_check_record() calls retain their native DNS record lists. Release the list before returning.
ndossche
reviewed
Oct 29, 2026
| } | ||
| } | ||
|
|
||
| status = DnsQuery_A(hostname, type, DNS_QUERY_STANDARD, NULL, &pResult, NULL); |
Member
There was a problem hiding this comment.
Apparently, the pResult argument is optional. In that case, isn't a cleaner fix to pass NULL? Then you wouldn't need a DnsRecordListFree call I suppose
Member
Author
There was a problem hiding this comment.
Tried it. The status is the same either way, but with a NULL result pointer dnsapi still builds the record list and nothing frees it: 20k DnsQuery_A() calls on Windows x64 grow private bytes by ~6.5 MB per batch for an A lookup, at least as much as the unpatched code, while freeing the list stays flat. So the DnsRecordListFree() call is needed.
ndossche
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows
checkdnsrr()and dns_check_record() now free the result list after successful lookups. Source review found the leak, and repeated native Windows x64 lookups confirmed the correction.