Repository navigation
Conversation
TimWolla
reviewed
Oct 29, 2026
TimWolla
approved these changes
Oct 29, 2026
kocsismate
approved these changes
Oct 30, 2026
Member
|
Applied as c95e572 |
Member
|
thank you for the fix! |
kairosci
pushed a commit
to kairosci/php-src
that referenced
this pull request
Oct 30, 2026
It happened during merging php#25026 to 8.5, because the same parameter wasn't const back then.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
port_str_to_zend_long_checked()rejected any port longer thanMAX_LENGTH_OF_LONGdigits before looking at its value, sohttp://example.com:000000000000000000008080/threw "The port is out of range" even though the port is 8080. RFC 3986 allows any number of digits, andUri\WhatWg\Urlalready accepts it. The leading zeros are now skipped before the length check.Fixes #25019