Repository navigation
Fix GH-25007: PFA named args in constant expression write out of bounds - #25012
Merged
Merged
Conversation
* up/PHP-8.6: Fix json_encode() reporting false "Recursion detected" after OOM for hooked-property objects (php#24992) Fix phpGH-25023: ZEND_CONTAINER_OF() fails to compile with -std=c11 (php#25027) Fix flaky FPM test for bug #77023 (php#24999) Update GitHub Action workflows to `actions/checkout@v7` (8.6) Update GitHub Action workflows to `actions/checkout@v7` (8.5) Update GitHub Action workflows to `actions/checkout@v7` (8.4) Update GitHub Action workflows to `actions/checkout@v7` Fix phpGH-23626: OPcache: orphaned temporaries cause leaks and assertions [ci skip] Fix comment Fix block pass dropping ZEND_FAST_CALL OP2 definition Fix phpGH-23572: JIT calls wrong static method from trait clones Fix phpGH-24784: Preserve certificates when reading PKCS7/CMS CRLs (php#24785)
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a constant expression,
zend_ast_evaluate_arg_list()added every named argument tonamed_positions, whilezend_compile_args_ex()only adds named placeholders.zp_compile()uses those positions to index theparamsarray, which only has room for the placeholders, sof(a: 1, b: ?)wrote past the end of it. Now only named placeholders get a position, same as the compiled path.Fixes #25007