Repository navigation
json - fix OOM error message on hook branch - #24992
Merged
Merged
Conversation
Member
|
Thank you @adapik. Could you add a test and a NEWS entry? |
adapik
force-pushed
the
fix/json-oom-unprotect-hooked-8.4
branch
2 times, most recently
from
October 29, 2026 06:38
68e881f to
77ba05d
Compare
Contributor
Author
|
PR updated: NEWS entry and test added. |
…hooked-property objects
adapik
force-pushed
the
fix/json-oom-unprotect-hooked-8.4
branch
from
October 29, 2026 07:37
77ba05d to
69af4b8
Compare
arnaud-lb
added a commit
that referenced
this pull request
Oct 29, 2026
* PHP-8.6: Fix json_encode() reporting false "Recursion detected" after OOM for hooked-property objects (#24992)
Member
|
Thank you! |
arnaud-lb
added a commit
to lazerg/php-src
that referenced
this pull request
Oct 29, 2026
* PHP-8.4: Fix json_encode() reporting false "Recursion detected" after OOM for hooked-property objects (php#24992)
arnaud-lb
added a commit
to lazerg/php-src
that referenced
this pull request
Oct 29, 2026
* PHP-8.5: Fix json_encode() reporting false "Recursion detected" after OOM for hooked-property objects (php#24992)
arnaud-lb
added a commit
to lazerg/php-src
that referenced
this pull request
Oct 29, 2026
* up/PHP-8.6: Fix json_encode() reporting false "Recursion detected" after OOM for hooked-property objects (php#24992) Fix phpGH-25023: ZEND_CONTAINER_OF() fails to compile with -std=c11 (php#25027) Fix flaky FPM test for bug #77023 (php#24999) Update GitHub Action workflows to `actions/checkout@v7` (8.6) Update GitHub Action workflows to `actions/checkout@v7` (8.5) Update GitHub Action workflows to `actions/checkout@v7` (8.4) Update GitHub Action workflows to `actions/checkout@v7` Fix phpGH-23626: OPcache: orphaned temporaries cause leaks and assertions [ci skip] Fix comment Fix block pass dropping ZEND_FAST_CALL OP2 definition Fix phpGH-23572: JIT calls wrong static method from trait clones Fix phpGH-24784: Preserve certificates when reading PKCS7/CMS CRLs (php#24785)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every exit path unprotects recursion_rc, except the ZEND_HAS_OOM() branch taken when escaping an object/array key fails. It unprotects myht instead, so for hooked classes the object keeps GC_PROTECTED set. That branch also returns without freeing tmp, the value read through the get hook, which the neighbouring error paths release.
Fixes a regression from 3584a98 - @arnaud-lb please have a look