Repository navigation
Conversation
iliaal
approved these changes
Oct 28, 2026
| after a handshake timeout. (Ilia Alshanetsky) | ||
| . Fixed feof() on a TLS stream staying false after a close_notify on Windows. | ||
| (Jakub Zelenka) | ||
| . Fixed bug GH-24784 (openssl_pkcs7_read() and openssl_cms_read() overwrite |
Member
There was a problem hiding this comment.
Move it into an OpenSSL subsection under the upcoming 8.4.28 release; otherwise, NEWS attributes the fix to the wrong version.
…te certificates The certificate and CRL loops both indexed the output array with their own counter, so each CRL replaced the certificate at the same index. Append with add_next_index_zval() instead.
adapik
force-pushed
the
openssl-crt-crl-mixup
branch
from
October 28, 2026 14:06
edb8c13 to
dfc1790
Compare
LamentXU123
approved these changes
Oct 28, 2026
iliaal
pushed a commit
to iliaal/php-src
that referenced
this pull request
Oct 28, 2026
* PHP-8.4: Fix phpGH-24784: Preserve certificates when reading PKCS7/CMS CRLs (php#24785)
arnaud-lb
added a commit
to lazerg/php-src
that referenced
this pull request
Oct 29, 2026
* up/PHP-8.6: Fix json_encode() reporting false "Recursion detected" after OOM for hooked-property objects (php#24992) Fix phpGH-25023: ZEND_CONTAINER_OF() fails to compile with -std=c11 (php#25027) Fix flaky FPM test for bug #77023 (php#24999) Update GitHub Action workflows to `actions/checkout@v7` (8.6) Update GitHub Action workflows to `actions/checkout@v7` (8.5) Update GitHub Action workflows to `actions/checkout@v7` (8.4) Update GitHub Action workflows to `actions/checkout@v7` Fix phpGH-23626: OPcache: orphaned temporaries cause leaks and assertions [ci skip] Fix comment Fix block pass dropping ZEND_FAST_CALL OP2 definition Fix phpGH-23572: JIT calls wrong static method from trait clones Fix phpGH-24784: Preserve certificates when reading PKCS7/CMS CRLs (php#24785)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes 24784
The certificate and CRL loops both indexed the output array with their own counter, so each CRL replaced the certificate at the same index. Append with add_next_index_zval() instead.