Repository navigation
Conversation
…_MIN Only the upper bound of $offset was checked before it is narrowed into an int32_t, so on 64-bit platforms e.g. -4294967295 was truncated to 1 and parsing started from there instead of failing.
LamentXU123
approved these changes
Oct 27, 2026
LamentXU123
left a comment
LamentXU123
left a comment
Member
There was a problem hiding this comment.
Not sure but I think it might be a common bug pattern to use ZEND_LONG_INT_OVFL for int32_t but not unsigned. Perhaps a good news for fuzzers?
LGTM.
LamentXU123
added a commit
that referenced
this pull request
Oct 28, 2026
* PHP-8.6: Merge branch 'PHP-8.5' into PHP-8.6 Fix IntlDateFormatter parse functions truncating an $offset below INT_MIN (#24781)
Member
|
Thank you very much! |
opensource-fork-sync Bot
pushed a commit
to cla7aye15I4nd/opensource-php__php-src
that referenced
this pull request
Oct 28, 2026
* PHP-8.4: Fix IntlDateFormatter parse functions truncating an $offset below INT_MIN (php#24781)
opensource-fork-sync Bot
pushed a commit
to cla7aye15I4nd/opensource-php__php-src
that referenced
this pull request
Oct 28, 2026
* PHP-8.5: Merge branch 'PHP-8.4' into PHP-8.5 Fix IntlDateFormatter parse functions truncating an $offset below INT_MIN (php#24781)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only the upper bound of $offset was checked before it is narrowed into an int32_t, so on 64-bit platforms e.g. -4294967295 was truncated to 1 and parsing started from there instead of failing.
This is split from #23688