Repository navigation
Conversation
kairosci
force-pushed
the
fix/gh-24286-jit-internal-call
branch
from
October 25, 2026 20:10
ae20d29 to
ab6e4fb
Compare
Member
|
In my patch I posted I also added comments to explain the reasoning, I think they should be kept, since you copy it anyway you should copy the comments too. |
Contributor
Author
|
Added! |
Co-authored-by: Nora Dossche <7771979+ndossche@users.noreply.github.com>
kairosci
force-pushed
the
fix/gh-24286-jit-internal-call
branch
from
October 29, 2026 15:28
cb60d8c to
4270fd5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #24286 using @ndossche's callee-type guard, with regression tests. OPcache validation passes on debug ZTS and optimized NTS builds.