Fix GH-23662: avoid NAN warning in print_r() - #23668
Open
CodedByManish wants to merge 1 commit into
Open
Conversation
|
Should we add the case for |
Author
I checked the scalar case as well. |
In my test, |
CodedByManish
force-pushed
the
fix/gh-23662-print-r-nan
branch
from
September 13, 2026 07:03
0c102c4 to
3b9d35a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #23662.
print_r()currently convertsdoublevalues through string coercion, which causes a warning when the value isNAN.Handle
IS_DOUBLEdirectly inzend_print_zval_r_to_buf()usingsmart_str_append_double(), soprint_r()formats the value without triggering a coercion warning.Added a regression test covering
print_r([NAN]).Tested with:
./sapi/cli/php -n run-tests.php Zend/tests/gh23662.phptResult: PASS.