ext/openssl: Defer pkcs7/cms verify output writes until verification succeeds - #23651
Open
iliaal wants to merge 1 commit into
Open
ext/openssl: Defer pkcs7/cms verify output writes until verification succeeds#23651iliaal wants to merge 1 commit into
iliaal wants to merge 1 commit into
Conversation
NickSdot
reviewed
Sep 11, 2026
| echo "p7bout sentinel intact? " . (file_get_contents($p7bout) === $sentinel ? "YES" : "NO") . "\n"; | ||
| echo "signers sentinel intact? " . (file_get_contents($signers) === $sentinel ? "YES" : "NO") . "\n"; | ||
|
|
||
| foreach ([$plain, $signed, $aCrt, $aKey, $bCrt, $dir . 'pkcs7_verify_nt_b.key.tmp', $content, $p7bout, $signers] as $f) { |
Member
Author
There was a problem hiding this comment.
Moved into --CLEAN--. The inline unlink was skipped whenever the sign step bailed out early.
iliaal
force-pushed
the
fix/openssl-ss004-pre-verify-truncation
branch
from
September 11, 2026 10:49
15ae602 to
079ba42
Compare
…succeeds openssl_pkcs7_verify() and openssl_cms_verify() opened the content and p7b output paths in write mode before verify, emptying existing files when verification failed. Buffer verified content in a memory BIO and write it only on success; open the p7b path only in that same success branch. Sibling audit: both verify functions shared the same early-open pattern; sign/encrypt paths already write after success.
iliaal
force-pushed
the
fix/openssl-ss004-pre-verify-truncation
branch
from
September 11, 2026 11:24
079ba42 to
43e37d7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
openssl_pkcs7_verify() and openssl_cms_verify() opened the output paths in write mode before verification, emptying existing files on failure. Verified content is buffered in memory and written only on success; the extra PKCS7/CMS output file is created only in that same success branch.