Repository navigation
perf: move EG() and CG() in ZTS builds into __thread storage #23227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
henderkes
wants to merge
31
commits into
php:master
Choose a base branch
from
henderkes:perf/1-tls-eg-cg
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+148
−173
Open
Changes from all commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
5af178b
perf: embed executor and compiler globals in the __thread TLS cache s…
henderkes 6494cd5
fix typo
henderkes b8cc198
remove ts_allocate_fast_id_at again (unused, now that the four global…
henderkes de08f98
guard ts_apply_for_id and ts_free_id for own threads globals too
henderkes ad1345b
clarification
henderkes 8c2f270
abort, rather than assert
henderkes 56a83ca
largely revert jit, just offsetof self* in the tsrm struct
henderkes 4f28aa3
LE guard for external embedders
henderkes 8b5c693
drop unused TSRMLS_MAIN_CACHE_DEFINE()
henderkes 54ce036
remove useless line
henderkes 8ec8026
move GC globals into __thread storage too
henderkes dcf8fbe
feedback: teb slot needs _m_x64
henderkes 1238c3b
feedback: precompute teb slot offset
henderkes 7d66f72
feedback: move macros into tsrm.h
henderkes b893abc
feedback: add zend_tsrmg_direct macro
henderkes 8bf2d99
feedback: move zend_win_tsrm_cache_init to tsrm.c
henderkes a6828cf
feedback: tsrm initializes tls slot
henderkes f0beb24
perf: non-volatile gs read on clang
henderkes 9fb4fc4
fix tests
henderkes 1f96e9c
fix gdb script
henderkes d730858
fall back to &_tsrm_ls_cache in case something blew the early TEB slo…
henderkes 307b8cc
suggestion: TlsFree in case of dll unload or late-TEB fallback
henderkes c1123c1
use ir TLS_ADDR
henderkes 4b270dd
cache index based tls jit too
henderkes b11b7b5
figure out linker relaxation for initial-exec
henderkes a40042e
fix old typo
henderkes 8809b41
aarch64 too
henderkes aefbb93
no surplus case gets global dynamic model
henderkes 47ee7c8
remove forward declaration
henderkes c5c8866
simplify jit?
henderkes 5367efc
drop Windows TEB fast path, cherry-pick this later in a follow-up PR
henderkes File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.