Open
Conversation
ZIP_RDONLY was introduced in libzip 1.0.0 which is required since a979e9f
Contributor
Author
|
Superseded, I included this commit in #21205 |
DanielEScherzer
approved these changes
Feb 12, 2026
Member
DanielEScherzer
left a comment
DanielEScherzer
left a comment
There was a problem hiding this comment.
Looks good to me - constant was added to zip in nih-at/libzip@ea8ba49 and that was included in the 1.0.0 release
I'll merge this in a few days if there are no objections
CC @devnexen from the patch bumping minimum version of libzip
ndossche
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ZIP_RDONLYwas introduced in libzip 1.0.0 which is required since a979e9f