Repository navigation
Conversation
go_read_post dropped read errors, so PHP saw a truncated php://input when Caddy's request_body max_size was exceeded.
henderkes
approved these changes
Oct 27, 2026
Contributor
|
I kind of dislike the silent exit TBH. I could imagine it leading to issues that are hard to debug. Throwing an error instead feels a bit better, but it would force every application to handle that error. What I'd actually prefer instead is maybe just buffering all chunked body requests per default so they never reach PHP before fully buffered. Makes it more consistent with what the CGI protocol expects. Similar idea to #2541. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
go_read_postdiscarded read errors, so PHP saw a truncatedphp://inputwhen Caddy'srequest_body max_size(or anyhttp.MaxBytesReader) was exceeded. The request is now rejected with 413 if the error is a*http.MaxBytesErrorand response headers have not been sent yet. This works in classic and worker mode.Fixes #2781