Fix incorrect claim that opcache_invalidate() skips the file cache - #5723
Open
GabrielCordeiroBarrosoTeles wants to merge 1 commit into
Open
Conversation
opcache_invalidate() has called zend_file_cache_invalidate() whenever opcache.file_cache is enabled since file cache support was added in 2015 (ZendAccelerator.c), which deletes the corresponding file cache entry. Update the description to reflect this instead of stating that only the in-memory cache is invalidated. Closes php#5696
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
opcache_invalidate()'s description states it "only invalidates in-memory cache and not file cache", which is incorrect.zend_accel_invalidate()inext/opcache/ZendAccelerator.ccallszend_file_cache_invalidate()wheneveropcache.file_cacheis enabled, which deletes the corresponding compiled file from the file cache (zend_file_cache_unlink()inext/opcache/zend_file_cache.c).Closes #5696
Test plan
configure.php(no local build environment set up here, would appreciate a CI check)