Conversation
There was a problem hiding this comment.
Pull request overview
Adds support and documentation for Nova server-create scheduler hints (specifically for placing servers into an existing server group) in the Compute v2 SDK workflow.
Changes:
- Add
schedulerHintsrequest option forcreateServer, serialized as top-levelos:scheduler_hintsalongside theserverobject. - Update Compute v2 API server-create request shaping to nest only server fields under
server.*while allowing top-level siblings (like scheduler hints). - Add sample + docs + sample test coverage for creating a server in a server group; improve sample cleanup reliability when deleting servers/networks.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/unit/Compute/v2/ServiceTest.php | Adds unit coverage asserting os:scheduler_hints is sent alongside server on create. |
| tests/sample/Compute/v2/TestCase.php | Ensures server addresses are retrieved before deletion so dependent network cleanup can run after delete. |
| tests/sample/Compute/v2/ServerGroupTest.php | Adds an integration/sample test demonstrating server creation inside a server group via scheduler hints. |
| src/Compute/v2/Params.php | Introduces schedulerHints parameter schema (sent as os:scheduler_hints). |
| src/Compute/v2/Api.php | Refactors postServer JSON shaping to use per-param JSON paths under server, enabling top-level scheduler hints. |
| samples/Compute/v2/server_groups/create_server.php | New executable sample showing schedulerHints.group usage on server create. |
| doc/services/compute/v2/server-groups.rst | Documents the new “Create a server in a group” workflow and links the sample. |
| AGENTS.md | Adds guidance for reusing resources in sample tests via @depends patterns. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for #434
add scheduler hints for server