fix navbar links and mobile layout issues - #15
Merged
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Navbar:
Home page hero spacing:
Horizontal overflow on narrow screens:
.navbar__logowas pinned toheight: 4remwith no responsive rule. The lockup is 4.5:1, so it rendered 288px wide with a right edge at 342px at every screen size, pushing the document sideways below that width. Under the navbar's 996px breakpoint the width now leads and the height follows (max-width: 55vw,max-height: 4rem); above it nothing changes and the logo is still exactly 288px.flex-shrink: 0on the Copy button, sitting at 361px regardless of viewport. It now wraps, dropping Copy to its own line when there is no room.Measured across 24 pages at 320px and 360px: every page overflowed by 22-41px before, all are at zero now. Code blocks are untouched — they extend past the viewport inside their own
overflow-x: autocontainers by design.