Repository navigation
test: pass robot documents in memory and drop empty trybuild globs - #527
Merged
Merged
Conversation
The robot document reaches generation through the override seam instead of a temporary file, so the schema-rejection and minimal-surface rules are tested against the document itself; loading a real file reaches the same validation through every scaffolded project in the build_api suite. The trybuild compiler contracts keep one fail case per distinct guarantee — surveying them found no redundant permutations to slim. What was empty is now gone instead: trybuild_host_ui matched no fixtures at all (its host_pass/host_fail directories never existed) and trybuild_ui's pass glob matched nothing, so both dead paths are removed and the module doc names where successful authored usage is actually proven — runtime_authoring and runtime_semantics, 106 deterministic tests that compile and run the real macro surfaces. Verified: phoxal-build lib 18/18; trybuild 5 fail cases in 26 s and the scenario suite (4 fail, 1 pass) in 63 s warm; clippy -D warnings and fmt clean. Signed-off-by: jbernavaprah <webjure@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Completes phase 3 of the accepted test-boundary refactor.
What changes
generate's override seam instead of a temporary file: the schema-rejection and minimal-surface rules are now tested against the document itself, in memory. Loading a real file reaches the same validation through every scaffolded project in thebuild_apiintegration suite.trybuild_host_uimatched no fixtures at all (itshost_pass/host_faildirectories never existed), andtrybuild_ui's pass glob matched nothing. Both dead paths are removed; the module doc now names where successful authored usage is actually proven —runtime_authoringandruntime_semantics, 106 deterministic tests that compile and run the real macro surfaces without invoking the compiler again.No deeper in-memory seams were added for phoxal-build: the two semantic tests that needed no filesystem no longer touch it, and the remaining generation tests legitimately need prepared products and directories — new seam machinery would serve no current test.
Verified
phoxal-buildlib: 18/18.clippy --workspace --all-targets -D warnings,fmt --checkclean.Delivery order
Single repository, no publication impact.