Repository navigation
Recover object-store readiness failures - #41
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DurableServer startup treated bucket readiness as only success or already-created, so a Req transport error escaped as a
CaseClauseError. Retrying the startup then exposed the same contract mismatch as a backend-readiness match failure.Retry idempotent bucket creation for transport failures, preserve exhausted errors, and report expected readiness failures as
:backend_unavailable. Invalid backend return shapes still raise as contract violations.CI's distributed placement test also requires EPMD, but the runner did not start it. Start EPMD explicitly before the test suite instead of invalidating the test on
:nodistribution.Evidence
{:error, %Req.TransportError{reason: binary()}}crashedensure_bucket_exists/1.409; exhausted transport errors remain explicit, typed startup failures.BalancedPlacementTestbecauseNode.start/2could not reach EPMD.Merge Danger
Blast radius: ObjectStore-backed supervisor startup readiness and CI test setup. A startup can make up to two additional idempotent bucket-create attempts for transport failures and the transient HTTP failures Req already retried. CI now runs one EPMD daemon for distributed tests.
There is no durable-state schema or stored-data change. A rollback restores the prior startup failure behavior; mixed versions do not share runtime state for this check.