Keep live servers running during degraded discovery - #24
Open
jeregrine wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A heartbeat cycle treated two different health signals as one operation: publishing this node's heartbeat and refreshing the cache of every peer heartbeat. If this node successfully proved its own liveness but one peer read failed, the lifecycle manager raised and stopped the supervisor tree, unnecessarily terminating already-owned DurableServers.
At the same time, proceeding with discovery from a partial peer view would be unsafe because it could make a live owner appear orphaned.
Fix
Separate local liveness from cluster discovery:
discovery_degraded.The resulting behavior is deliberately asymmetric:
Supporting information
The degraded marker is published through the supervisor's shared ETS coordination table so lock and placement paths can fail closed immediately without synchronously calling the lifecycle manager. The lifecycle manager also rechecks the marker immediately before restart claims and remote placement attempts, closing races with work that began before reconciliation degraded.
No public configuration or storage schema changes are required.