Conversation
- Add theme toggle button (sun/moon) in md viewer embedded toolbar, visible in both edit and reader modes - Theme persisted via PreferencesManager preference (mdViewerTheme) - Communication: iframe sends mdviewrThemeToggle → MarkdownSync persists and sends MDVIEWR_SET_THEME back to apply - Content max-width changed to 90ch for paper-like readability - Responsive padding: 70px on wider viewports, 24px on narrow - Collapse all toolbar format groups below 590px panel width - Update CLAUDE.md and CLAUDE-markdown-viewer.md to document md viewer's own i18n system (src-mdviewer/src/locales/en.json)
The checkbox enable/disable test was flaky because _getCheckboxes() ran before the DOM re-rendered after mode switch. Add awaitsFor to wait for checkboxes to appear before asserting.
- Fix scroll position destroyed when panel is hidden then reopened: saveActiveScrollPos now skips saving when viewer is hidden (scrollTop=0 from hidden element would overwrite the correct cached value) - Stricter theme skip: check both data-theme attr and colorScheme style - Increase panel reopen scroll test timeout for CI stability
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.