rename when_failed to when_exhausted for clarity #602
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| Name | Type |
|---|---|
| @pgflow/core | Minor |
| @pgflow/dsl | Minor |
| pgflow | Minor |
| @pgflow/client | Minor |
| @pgflow/edge-worker | Minor |
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
This was referenced Jan 23, 2026
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
View your CI Pipeline Execution ↗ for commit b477dc6
☁️ Nx Cloud last updated this comment at |
jumski
force-pushed
the
01-23-rename_when_failed_to_when_exhausted
branch
from
d31e730 to
960485f
Compare
jumski
force-pushed
the
01-22-client_skipped_event_support
branch
from
3858291 to
192d2c0
Compare
jumski
changed the base branch from
01-22-client_skipped_event_support
to
graphite-base/602
jumski
force-pushed
the
graphite-base/602
branch
from
192d2c0 to
6bad9b5
Compare
jumski
force-pushed
the
01-23-rename_when_failed_to_when_exhausted
branch
from
960485f to
44d1614
Compare
jumski
changed the base branch from
graphite-base/602
to
01-22-client_skipped_event_support
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
jumski
force-pushed
the
01-23-rename_when_failed_to_when_exhausted
branch
from
44d1614 to
ecad8a3
Compare
jumski
force-pushed
the
01-22-client_skipped_event_support
branch
from
6bad9b5 to
c86955f
Compare
jumski
force-pushed
the
01-23-rename_when_failed_to_when_exhausted
branch
from
ecad8a3 to
b477dc6
Compare
Contributor
🔍 Preview Deployment: Website✅ Deployment successful! 🔗 Preview URL: https://pr-602.pgflow.pages.dev 📝 Details:
_Last updated: _ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename
when_failedtowhen_exhaustedfor ClarityThis PR renames the
when_failedparameter towhen_exhaustedthroughout the codebase to better reflect its purpose. The parameter controls what happens when a step's retry attempts are exhausted, not just when it fails once.Key changes:
when_failedtowhen_exhaustedretriesExhaustedtowhenExhaustedfor consistency withwhenUnmetThis change improves clarity by making the parameter name more accurately describe its behavior - it only takes effect after all retry attempts are exhausted, not on the first failure.