Skip to content

clickbench, the saga#984

Draft
levkk wants to merge 1 commit into
mainfrom
levkk-clickbench-p1
Draft

clickbench, the saga#984
levkk wants to merge 1 commit into
mainfrom
levkk-clickbench-p1

Conversation

@levkk
Copy link
Copy Markdown
Collaborator

@levkk levkk commented May 18, 2026

Clickbench tests!

Many failures, but start with this one:

FAILED test_sql_regression.py::test_sql_regression[942_clickbench_q03] - AssertionError: case=942_clickbench_q03 statement_index=0 baseline=postgres_standard_text candidate=pgdog_sharded_text: column names mismatch -> ('sum', 'count', 'avg') vs ('sum', 'count', 'avg', '__pgdog_count_expr2_col2')

========================================================================================================================== FAILURES ==========================================================================================================================
__________________________________________________________________________________________________________ test_sql_regression[942_clickbench_q03] ___________________________________________________________________________________________________________

case = CaseDefinition(id='942_clickbench_q03', description='ClickBench Citus query 3', path=PosixPath('/home/lev/code/pgdog/i...=True, only_targets=('postgres_standard_text', 'pgdog_sharded_text', 'pgdog_sharded_binary'), skip_targets=frozenset())

    @pytest.mark.parametrize("case", SUITE.cases, ids=lambda c: c.id)
    def test_sql_regression(case):
>       run_case(SUITE, case)

test_sql_regression.py:10: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
lib.py:343: in run_case
    _assert_all_equal(case, targets, results)
lib.py:408: in _assert_all_equal
    _assert_pair_equal(case, baseline_cfg, candidate_cfg, baseline_results, candidate_results)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

case = CaseDefinition(id='942_clickbench_q03', description='ClickBench Citus query 3', path=PosixPath('/home/lev/code/pgdog/i...=True, only_targets=('postgres_standard_text', 'pgdog_sharded_text', 'pgdog_sharded_binary'), skip_targets=frozenset())
baseline_cfg = ConnectionConfig(name='postgres_standard_text', dsn='postgresql://pgdog:pgdog@127.0.0.1:5432/pgdog?gssencmode=disable', format='text', tags=frozenset({'standard'}))
candidate_cfg = ConnectionConfig(name='pgdog_sharded_text', dsn='postgresql://pgdog:pgdog@127.0.0.1:6432/pgdog_sharded?gssencmode=disable', format='text', tags=frozenset({'sharded'}))
baseline_results = [StatementResult(sql='SELECT SUM(AdvEngineID), COUNT(*), AVG(ResolutionWidth) FROM hits;', status='SELECT 1', rowcount...'sum', 'count', 'avg'), type_names=('bigint', 'bigint', 'numeric'), rows=((6, 15, Decimal('1228.7333333333333333')),))]
candidate_results = [StatementResult(sql='SELECT SUM(AdvEngineID), COUNT(*), AVG(ResolutionWidth) FROM hits;', status='SELECT 1', rowcount...2_col2'), type_names=('bigint', 'bigint', 'numeric', 'bigint'), rows=((6, 15, Decimal('1228.7333333333333333'), 15),))]

@codecov
Copy link
Copy Markdown

codecov Bot commented May 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@blacksmith-sh
Copy link
Copy Markdown
Contributor

blacksmith-sh Bot commented May 18, 2026

Found 1 test failure on Blacksmith runners:

Failure

Test View Logs
test_sql_regression[942_clickbench_q03] View Logs

Fix in Cursor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant