Skip to content

feat(replication): add retry logic#966

Merged
meskill merged 5 commits into
mainfrom
fix/replication_retry
May 20, 2026
Merged

feat(replication): add retry logic#966
meskill merged 5 commits into
mainfrom
fix/replication_retry

Conversation

@meskill
Copy link
Copy Markdown
Contributor

@meskill meskill commented May 7, 2026

  • Adds lock_timeout configuration setting to pass it to pg server
  • Adds retry mechanism for the replication.

This at some degree could help with the cross-shared dead-locks and fix the issue with tests in #924 if configured

@meskill meskill force-pushed the fix/replication_retry branch from 3ed3d9e to f4e2d78 Compare May 10, 2026 21:13
@meskill meskill force-pushed the push-tmpxoryqppmp branch from d395b91 to 2cc4e22 Compare May 10, 2026 21:13
@codecov
Copy link
Copy Markdown

codecov Bot commented May 10, 2026

@blacksmith-sh

This comment has been minimized.

@meskill meskill force-pushed the fix/replication_retry branch 2 times, most recently from 0b6839d to 5b9e79d Compare May 10, 2026 22:48
@meskill meskill marked this pull request as ready for review May 10, 2026 22:53
@levkk
Copy link
Copy Markdown
Collaborator

levkk commented May 16, 2026

#968 feels like the better/right approach.

@meskill
Copy link
Copy Markdown
Contributor Author

meskill commented May 18, 2026

#968 feels like the better/right approach.

Yes, the #968 is more targeted approach to solve the issue with tests. But I suggest to consider this pr as a general improvement that adds new configuration and adds retries to replication process. The features could be used to fix the resharding test but this could be useful in general

@meskill meskill force-pushed the push-tmpxoryqppmp branch 2 times, most recently from 0361bc0 to 1cd4312 Compare May 19, 2026 18:27
@meskill meskill force-pushed the fix/replication_retry branch from 5b9e79d to 69062ad Compare May 19, 2026 21:59
@meskill meskill force-pushed the push-tmpxoryqppmp branch from 1cd4312 to 14ffc63 Compare May 19, 2026 23:01
@meskill meskill force-pushed the fix/replication_retry branch from 69062ad to 48d0f0a Compare May 19, 2026 23:02
Base automatically changed from push-tmpxoryqppmp to main May 20, 2026 10:05
@meskill meskill force-pushed the fix/replication_retry branch from 48d0f0a to fb44927 Compare May 20, 2026 10:07
Copy link
Copy Markdown
Collaborator

@levkk levkk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@meskill meskill force-pushed the fix/replication_retry branch from fa024b4 to a5b20bb Compare May 20, 2026 11:55
@meskill meskill merged commit daa6219 into main May 20, 2026
24 checks passed
@meskill meskill deleted the fix/replication_retry branch May 20, 2026 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants