feat(replication): add retry logic#966
Merged
Merged
Conversation
3ed3d9e to
f4e2d78
Compare
d395b91 to
2cc4e22
Compare
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
This comment has been minimized.
This comment has been minimized.
0b6839d to
5b9e79d
Compare
Collaborator
|
#968 feels like the better/right approach. |
Contributor
Author
Yes, the #968 is more targeted approach to solve the issue with tests. But I suggest to consider this pr as a general improvement that adds new configuration and adds retries to replication process. The features could be used to fix the resharding test but this could be useful in general |
0361bc0 to
1cd4312
Compare
5b9e79d to
69062ad
Compare
1cd4312 to
14ffc63
Compare
69062ad to
48d0f0a
Compare
48d0f0a to
fb44927
Compare
f8be481 to
fa024b4
Compare
fa024b4 to
a5b20bb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This at some degree could help with the cross-shared dead-locks and fix the issue with tests in #924 if configured