Repository navigation
feat: derive mTLS identity from URI SANs, not just dNSName - #1934
Merged
Merged
Conversation
Workload identity platforms (SPIFFE, SPIRE, Istio, GKE managed workload identity) assert identity as a `spiffe://` URI SAN and issue no `dNSName`, so their certificates resolved to no identity and were rejected even when signed by the configured client CA. `identity_from_certs` now prefers `dNSName`, then `uniformResourceIdentifier`, then Subject CN. The URI is matched verbatim against `[[users]] identity`; no scheme-specific parsing. Certificates that resolved before resolve identically. Closes pgdogdev#1893 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
|
Contributor
|
Metal bench skipped! Fork PRs are not run on yet for safety reasons. |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Workload identity platforms (SPIFFE, SPIRE, Istio, GKE managed workload identity) assert identity as a
spiffe://URI SAN and issue nodNSName, so their certificates resolved to no identity and were rejected even when signed by the configured client CA.identity_from_certsnow prefersdNSName, thenuniformResourceIdentifier, then Subject CN. The URI is matched verbatim against[[users]] identity; no scheme-specific parsing. Certificates that resolved before resolve identically.Closes #1893