Fix an issue where pgAdmin4 app on macOS cannot auto-update while run…#9582
Merged
adityatoshniwal merged 2 commits intopgadmin-org:masterfrom Feb 2, 2026
Merged
Conversation
…ning on a read-only volume even if present in /Applications folder. pgadmin-org#9402
WalkthroughRemoved a macOS quarantine flag and added an application category in the macOS Info.plist; prevented Python from writing .pyc files during build and runtime; added a purge of pycache and .pyc files before code signing. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@pkg/mac/build-functions.sh`:
- Around line 129-130: Move the export of PYTHONDONTWRITEBYTECODE into the start
of the _create_python_env() function so it is set before any Python commands run
(including ensurepip and pip install); locate the _create_python_env() function
and place the export PYTHONDONTWRITEBYTECODE=1 as the first statement in that
function to prevent generation of __pycache__/.pyc during those steps.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ning on a read-only volume even if present in /Applications folder. #9402
Summary by CodeRabbit