Skip to content

Add dnf retry loop to Dockerfile-base.el9 to reduce CI flakiness #539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mason-sharp wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add dnf retry loop to Dockerfile-base.el9 to reduce CI flakiness #539

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 21 additions & 5 deletions tests/docker/Dockerfile-base.el9
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,9 +65,17 @@ RUN set -eux && \
# System Update and Base Development Tools Installation
# ==============================================================================
RUN set -eux && \
dnf -y upgrade && \
dnf -y install sudo && \
dnf -y groupinstall "Development Tools" && \
for i in $(seq 1 5); do \
if dnf -y --refresh upgrade && \
dnf -y install sudo && \
dnf -y groupinstall "Development Tools"; then \
break; \
fi; \
if [ "$i" -eq 5 ]; then echo "dnf failed after 5 attempts" >&2; exit 1; fi; \
echo "dnf attempt $i failed; clearing metadata, retrying in 5s..." >&2; \
dnf clean all; \
sleep 5; \
done && \
dnf clean all && \
rm -rf /var/cache/dnf/*

Expand All @@ -86,7 +94,8 @@ RUN set -eux && \
# ==============================================================================
# Install all required packages in a single RUN to minimize layers
RUN set -eux && \
dnf install --allowerasing --enablerepo=crb -y \
for i in $(seq 1 5); do \
if dnf install --refresh --allowerasing --enablerepo=crb -y \
bind-utils \
bison \
clang \
Expand Down Expand Up @@ -126,7 +135,14 @@ RUN set -eux && \
unzip \
uuid-devel \
zlib-devel \
libzstd-devel && \
libzstd-devel; then \
break; \
fi; \
if [ "$i" -eq 5 ]; then echo "dnf failed after 5 attempts" >&2; exit 1; fi; \
echo "dnf attempt $i failed; clearing metadata, retrying in 5s..." >&2; \
dnf clean all; \
sleep 5; \
done && \
dnf clean all && \
rm -rf /var/cache/dnf/* /tmp/* /var/tmp/*

Expand Down
Loading