Skip to content

New test stories added in ci/journey.sh#48

Open
imtiazqa wants to merge 6 commits into
mainfrom
test/automate-manual-tcs
Open

New test stories added in ci/journey.sh#48
imtiazqa wants to merge 6 commits into
mainfrom
test/automate-manual-tcs

Conversation

@imtiazqa

Copy link
Copy Markdown
Collaborator

TC-022 — Verifies that a wrong S3 endpoint causes the archiver to fail at Phase 2 with a clear connection error naming the bad host
TC-024 — Verifies that an empty (0-row) partition completes all six archiver phases cleanly and is dropped from PostgreSQL
TC-040 — Verifies that renaming the hot table triggers the DDL hook to update the registry and rebuild the view, and DML via the view continues to route correctly
TC-052 — Verifies that partitioner set --retention updates partition_config in the database without touching the YAML file
TC-053 — Verifies that a disabled table is silently excluded from archiver runs and re-enabling it restores normal processing
TC-054 — Verifies that partitioner remove deletes the partition_config row while leaving the physical table intact
TC-071 — Verifies that a composite PARTITION BY RANGE (col1, col2) key is rejected by the archiver before any Iceberg or S3 work
TC-118 — Verifies that an archiver.tables block in the YAML config is ignored at runtime; the archiver always drives off partition_config
TC-119 — Verifies that export → delete row → import restores a partition_config entry (backup/restore cycle works correctly)
TC-120 — Verifies that archiver set writes only to partition_config; the YAML config file on disk is not modified

@imtiazqa
imtiazqa requested a review from vyruss as a code owner July 15, 2026 08:36
@coderabbitai

coderabbitai Bot commented Jul 15, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: f00b0d28-5c97-4dc6-9380-a3df0f058931

📥 Commits

Reviewing files that changed from the base of the PR and between c838280 and 5335b87.

📒 Files selected for processing (2)
  • ci/journey.sh
  • cmd/archiver/main.go

📝 Walkthrough

Walkthrough

Changes

Archiver and partitioner behavior

Layer / File(s) Summary
Stale partition drop cleanup
cmd/archiver/main.go
Already-archived partition cleanup now logs the condition and drops the partition without explicitly detaching it from its parent.
Configuration and partitioner management coverage
ci/journey.sh
Adds TC-118, TC-119, TC-120, TC-040, TC-052, TC-053, and TC-054 for database-backed configuration, export/import, table renaming, retention, enablement, and removal; wires them into tiered execution.
Tiered archiver execution coverage
ci/journey.sh
Adds TC-022, TC-024, and TC-071 for invalid S3 endpoints, empty partitions, and composite RANGE key rejection.

Estimated code review effort: 3 (Moderate) | ~30 minutes

Suggested reviewers: vyruss

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly reflects the main change: new journey test stories were added to ci/journey.sh.
Description check ✅ Passed The description directly summarizes the new TC journey stories added in ci/journey.sh.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch test/automate-manual-tcs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 duplication

Metric Results
Duplication 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant