test: add archiver crash rollback and partitioner FK drop rollback journey stories#45
Conversation
|
Warning Review limit reached
Next review available in: 25 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis PR adds two tiered E2E stories to ChangesJourney script E2E stories
Estimated code review effort: 3 (Moderate) | ~20 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Up to standards ✅🟢 Issues
|
vyruss
left a comment
vyruss
left a comment
There was a problem hiding this comment.
The 1st story can pass without testing what it claims. The fixed sleep 10 before the kill doesn't know if the archiver has reached the post-Phase-2 hold. On slow runners we can kill it before any cold rows are in Iceberg and all the assertions will pass anyway (crash-row only leaves PG at cutover, which never runs; the re-run is then just a clean first archive). So the Phase 0 self-heal path the story exists to test never actually runs.
Making the kill depend on the debug-export-delay log marker like story_concurrency already does. This also makes the kill happen after the export commits, so we don't need a special case for mesh mode.
The 2nd story is fine.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@ci/journey.sh`:
- Around line 1763-1767: Update the rollback test loop around the
debug-export-delay timeout so that a timeout or early archiver exit performs the
same cleanup of temporary partition_config and rb_events state as the normal
path before returning. Reuse the existing teardown logic rather than exiting
directly, while preserving the current success behavior when the marker is
found.
- Around line 1768-1773: Ensure the archiver crash-test function always cleans
up its created rb_events, partition_config, and table state when the hold-marker
is not reached. Add a function-scope RETURN trap or invoke the existing cleanup
before the early return in the reached check, then remove the redundant manual
cleanup block at the function end while preserving normal success behavior.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: a6d8a4b4-b922-4677-a625-8f2cd3e545cb
📒 Files selected for processing (1)
ci/journey.sh
…nd clean up on every exit path
f8780b3 to
5c600b2
Compare
2 participants
Adds two journey stories covering rollback behavior:
Archiver crash rollback — kills the archiver mid Phase 2, asserts data stays in PG, verifies Phase 0 self-heals on re-run
Partitioner FK drop rollback — inbound FK blocks expired partition drop, asserts fail-fast with SQLSTATE 23503 (no retry loop), self-heals after FK reference removed. Skipped in mesh mode with a NOTE.