Skip to content

fix: Graph.__str__ separates thousands in its counts - #57

Merged
petercorke merged 3 commits into
mainfrom
fix/graph-str-thousands
Oct 12, 2026
Merged

petercorke merged 3 commits into
mainfrom
fix/graph-str-thousands

Conversation

@petercorke

Copy link
Copy Markdown
Owner

str(g) of a large graph is easier to read with separators: DGraph: 4,881 vertices, 8,392 edges, 14 components instead of 4881 … 8392. Counts below 1,000 are unchanged, so the existing golden strings ("UGraph: 2 vertices, 1 edge, 1 component") are unaffected; I checked the tests, the docs, the example notebooks and the other toolbox repos for a golden Graph: N vertices string and the only one that changes is a stored notebook output.

One format spec on the three counts, the docstring says so, and a test covers 999 and 1,001.

🤖 Generated with Claude Code

A graph of 4883 vertices now prints as 4,883 vertices, 8,392 edges, which is
easier to read.  Counts below 1,000 are as before.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@codacy-production

codacy-production Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 6 complexity · 0 duplication

Metric Results
Complexity 6
Duplication 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@codecov

codecov Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.41%. Comparing base (5c64e4b) to head (2a0aac2).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #57   +/-   ##
=======================================
  Coverage   96.41%   96.41%           
=======================================
  Files           3        3           
  Lines        1339     1339           
=======================================
  Hits         1291     1291           
  Misses         48       48           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

petercorke and others added 2 commits October 13, 2026 08:54
Replaces the star import, which Codacy reports as F405 on every changed line
that uses one of the names.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@petercorke
petercorke merged commit 149abc1 into main Oct 12, 2026
12 checks passed
@petercorke
petercorke deleted the fix/graph-str-thousands branch October 12, 2026 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant