Repository navigation
refactor: make graph constructor arguments keyword-only - #41
Merged
Merged
Conversation
In 0.6.5 the first positional argument was accepted and ignored, so UGraph(6) looked as though it set a dimension but did nothing. With the current signature it would land in metric. Making every argument keyword-only turns UGraph(6) into a clear TypeError. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
petercorke
force-pushed
the
refactor/keyword-only-graph-constructor
branch
from
October 11, 2026 23:26
5e62b9c to
31fb30d
Compare
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 4 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #41 +/- ##
=======================================
Coverage 94.60% 94.60%
=======================================
Files 3 3
Lines 1205 1205
=======================================
Hits 1140 1140
Misses 65 65 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Every
BaseGraph/UGraph/DGraphconstructor argument is now keyword-only.In 0.6.5 the first positional parameter (
arg) was accepted and silently ignored, soUGraph(6)looked as though it set a dimension but did nothing. With the current signature the6would land inmetric. Making the arguments keyword-only turns the mistake into a clearTypeError.Breaking change (1.0)
UGraph(6),UGraph("L2")etc. now raiseTypeError; useUGraph(dim=6),UGraph(metric="L2").I checked the downstream code. RTB calls
UGraph(),UGraph(verbose=...),DGraph(metric="SE2")only. MVTBBundleAdjustcalledpgraph.UGraph(6), which is fixed independently in petercorke/machinevision-toolbox-python#127 (it usesUGraph(), since views are 6D and landmarks 3D, sodim=6would be wrong), and works on both 0.6.5 and 1.0.Tests
tests/test_constructor_keywords.py: positional arguments are rejected for both graph kinds, keywords accepted, no-argument form still works.🤖 Generated with Claude Code