Repository navigation
refactor: vertex kinds supply _detach, the twin of _attach; removed vertices leave the graph - #38
Merged
Merged
Conversation
… graph Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…ertices leave the graph remove_edge knew how each vertex kind held an edge (a per-endpoint 'is it in this list?' check written for the directed case). That is now the vertex kind's job: UVertex._detach removes the edge from both ends (twice for a self-loop) and DVertex._detach from the source. remove_edge calls it once, before clearing the edge's endpoints. Behaviour is unchanged. Also fixes remove_vertex leaving vertex._graph pointing at the graph it had been removed from, which made a later connect() report 'different graphs' rather than 'not in a graph', and made vertex.remove() fail confusingly. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 33 |
| Duplication | 4 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #38 +/- ##
==========================================
+ Coverage 93.63% 93.79% +0.15%
==========================================
Files 3 3
Lines 1053 1063 +10
==========================================
+ Hits 986 997 +11
+ Misses 67 66 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
remove_edgeknew how each vertex kind held an edge: a per-endpoint "is it in this list?" check written for the directed case. That is now the vertex kind's job, as_attachalready is forconnect:UVertex._detachremoves the edge from both ends (twice for a self-loop);DVertex._detachfrom the source.remove_edgecalls it once, before clearing the edge's endpoints. Behaviour is unchanged.Also fixes
remove_vertexleavingvertex._graphpointing at the graph it had been removed from. That made a laterconnect()report "different graphs" rather than "not in a graph", and madevertex.remove()fail confusingly.Tests
tests/test_detach_hook.py:_detachis the exact inverse of_attachfor both kinds (including loops and parallel edges), and a removed vertex leaves its graph.🤖 Generated with Claude Code