Repository navigation
fix: graph[x] returned None for NumPy integers and other types - #28
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
__getitem__ fell off the end and returned None for anything that was not a Python int, str or vertex -- including np.int64, so g[np.argmin(d)] quietly gave None. NumPy integers are now accepted, and any other type raises TypeError. Exceptions are documented. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #28 +/- ##
==========================================
+ Coverage 87.59% 87.60% +0.01%
==========================================
Files 2 2
Lines 814 815 +1
==========================================
+ Hits 713 714 +1
Misses 101 101 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 11 |
| Duplication | 2 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
graph[x]fell off the end of__getitem__and returnedNonefor anything that wasn't a Pythonint,stror vertex.The consequential case is NumPy integers:
g[np.argmin(d)]quietly gaveNone, which then fails somewhere far away.Change
np.integeraccepted alongsideint.TypeError.IndexError/KeyError/TypeErrorbehavior is documented in the docstring (which also had a mis-formatted bullet list).Tests
tests/test_getitem.py: int, negative int,np.int64,np.argminresult, name, vertex, unknown name, out-of-range, and a set of wrong types.🤖 Generated with Claude Code