fix: remove dead numpy.char.array import triggering chararray deprecation - #98
Merged
Merged
Conversation
…tion from numpy.char import array at Sources.py:28 was unused -- every actual array( call in the file is np.array(...) (a different function) or a local variable that happens to be named array. The import served no purpose and only existed to trigger numpy's "chararray class is deprecated" warning on every import of the package, seen throughout the test suite. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Up to standards ✅🟢 Issues
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
from numpy.char import arrayatSources.py:28was unused -- confirmed viagrep -n "[^.]\barray(" src/machinevisiontoolbox/Sources.py, which returns zero hits. Every realarray(...)call in the file isnp.array(...)(a different function) or a local variable that happens to be namedarray."The chararray class is deprecated"DeprecationWarningon every import of the package -- visible throughout the test suite's warning summary.Fix
Delete the unused import. No behavior change.
Test plan
import machinevisiontoolbox.Sources(captured viawarnings.catch_warnings).🤖 Generated with Claude Code