fix: catch cv2.error in points2F(), not just F/mask=None - #101
Open
petercorke wants to merge 1 commit into
Open
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
cv2.findFundamentalMat() doesn't always fail cleanly on degenerate point configurations -- sometimes it raises a raw C++ assertion (a Mat rowRange error) instead of returning (None, None). Both are the same underlying condition (points too degenerate to estimate F), so catch cv2.error alongside the existing None-check and re-raise as the same descriptive ValueError. Surfaced by RVC3-python's visodom.py example, which already expects and catches ValueError from points2F() to skip degenerate frames in a temporal-matching loop -- the raw cv2.error was slipping past that except clause uncaught. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
petercorke
force-pushed
the
fix/points2f-cv2-error-degenerate-points
branch
from
August 17, 2026 23:35
a4b3e41 to
c4197cb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan