fix: commit missing vloop_test/ploop_test model fixtures - #41
Open
petercorke wants to merge 1 commit into
Open
Conversation
These were never actually tracked in git -- they only "worked" because they sat as untracked files in local working directories, invisible under the old blanket `*test*` .gitignore rule removed in #40. A clean checkout doesn't have them, which breaks: - rvctool --test's bdsim check (imports vloop_test directly) - figures/code/chapter9/fig9_13.py, fig9_14.py (import ploop_test) - notebooks/scripts/chap9.py (%run -m ploop_test -H)
This was referenced Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RVC3/models/vloop_test.py/.bdandRVC3/models/ploop_test.py/.bdwere never actually tracked in git. They only "worked" because they sat as untracked files in local working directories, invisible under the blanket*test*.gitignorerule removed in #40. Discovered by runningpytest tests/ --runallin a genuinely clean worktree, which a real clean checkout doesn't have and breaks:rvctool --test's bdsim check (RVC3/bin/rvctool.pyimportsvloop_testdirectly)figures/code/chapter9/fig9_13.py,fig9_14.py(importploop_test)notebooks/scripts/chap9.py(%run -m ploop_test -H)Test plan
pytest tests/test_bin.pyfails onmainin a clean worktree withNo module named 'vloop_test'before this change