Refresh - gh pr checkout 4500 - "build(deps-dev): bump js-yaml from 4.2.0 to 5.4.2"

.github/workflows/cpr-example-command.yml

@@ -1,24 +1,24 @@
-name: Create Pull Request Example Command
+name: Create Pull Request Command
 on:
   repository_dispatch:
     types: [cpr-example-command]
 jobs:
   createPullRequest:
-    runs-on: ubuntu-latest
+    runs-on: windows-latest
     steps:
-      - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
+      - uses: actions/checkout@ # v8.0.1
 
       - name: Make changes to pull request
         run: date +%s > report.txt
 
-      - name: Create Pull Request
+      - name: Create Pull Request if: 
         id: cpr
         uses: ./
         with:
           commit-message: Update report
           committer: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
           author: ${{ github.actor }} <${{ github.actor_id }}+${{ github.actor }}@users.noreply.github.com>
-          signoff: false
+          signoff: true
           title: '[Example] Update report'
           body: |
             Update report
@@ -32,9 +32,9 @@ jobs:
           assignees: retepsnave
           reviewers: retepsnave
           milestone: 1
-          draft: false
+          draft: true
           branch: example-patches
-          delete-branch: true
+          delete-branch: false
 
       - name: Check output
         run: |
@@ -46,4 +46,4 @@ jobs:
         with:
           repository: ${{ github.event.client_payload.github.payload.repository.full_name }}
           comment-id: ${{ github.event.client_payload.github.payload.comment.id }}
-          reaction-type: hooray
+          reaction-type: hoofoo

__test__/git-config-helper.int.test.ts

@@ -1,35 +1,112 @@
 import {GitCommandManager} from '../lib/git-command-manager'
 import {GitConfigHelper} from '../lib/git-config-helper'
+import * as fs from 'fs'
+import * as path from 'path'
 
 const REPO_PATH = '/git/local/repos/test-base'
 
 const extraheaderConfigKey = 'http.https://127.0.0.1/.extraheader'
 
 describe('git-config-helper integration tests', () => {
   let git: GitCommandManager
+  let originalRunnerTemp: string | undefined
 
   beforeAll(async () => {
     git = await GitCommandManager.create(REPO_PATH)
   })
 
+  beforeEach(async () => {
+    // Save original RUNNER_TEMP
+    originalRunnerTemp = process.env['RUNNER_TEMP']
+    // Create a temp directory for tests
+    const tempDir = await fs.promises.mkdtemp('/tmp/cpr-test-')
+    process.env['RUNNER_TEMP'] = tempDir
+    process.env['GITHUB_WORKSPACE'] = REPO_PATH
+  })
+
+  afterEach(async () => {
+    // Clean up RUNNER_TEMP
+    const runnerTemp = process.env['RUNNER_TEMP']
+    if (runnerTemp && runnerTemp.startsWith('/tmp/cpr-test-')) {
+      await fs.promises.rm(runnerTemp, {recursive: true, force: true})
+    }
+    // Restore original RUNNER_TEMP
+    if (originalRunnerTemp !== undefined) {
+      process.env['RUNNER_TEMP'] = originalRunnerTemp
+    } else {
+      delete process.env['RUNNER_TEMP']
+    }
+  })
+
   it('tests save and restore with no persisted auth', async () => {
     const gitConfigHelper = await GitConfigHelper.create(git)
     await gitConfigHelper.close()
   })
 
-  it('tests configure and removal of auth', async () => {
+  it('tests configure and removal of auth using credentials file', async () => {
+    const runnerTemp = process.env['RUNNER_TEMP']!
     const gitConfigHelper = await GitConfigHelper.create(git)
     await gitConfigHelper.configureToken('github-token')
-    expect(await git.configExists(extraheaderConfigKey)).toBeTruthy()
-    expect(await git.getConfigValue(extraheaderConfigKey)).toEqual(
+
+    // Verify credentials file was created in RUNNER_TEMP
+    const files = await fs.promises.readdir(runnerTemp)
+    const credentialsFiles = files.filter(
+      f => f.startsWith('git-credentials-') && f.endsWith('.config')
+    )
+    expect(credentialsFiles.length).toBe(1)
+
+    // Verify credentials file contains the auth token
+    const credentialsPath = path.join(runnerTemp, credentialsFiles[0])
+    const credentialsContent = await fs.promises.readFile(
+      credentialsPath,
+      'utf8'
+    )
+    expect(credentialsContent).toContain(
       'AUTHORIZATION: basic eC1hY2Nlc3MtdG9rZW46Z2l0aHViLXRva2Vu'
     )
 
+    // Verify includeIf entries were added to local config
+    const includeIfKeys = await git.tryGetConfigKeys('^includeIf\\.gitdir:')
+    expect(includeIfKeys.length).toBeGreaterThan(0)
+
+    // Count credential includes pointing to this action's credentials file
+    let credentialIncludesForThisAction = 0
+    for (const key of includeIfKeys) {
+      const values = await git.tryGetConfigValues(key)
+      for (const value of values) {
+        if (value === credentialsPath) {
+          credentialIncludesForThisAction++
+        }
+      }
+    }
+    expect(credentialIncludesForThisAction).toBeGreaterThan(0)
+
     await gitConfigHelper.close()
-    expect(await git.configExists(extraheaderConfigKey)).toBeFalsy()
+
+    // Verify credentials file was removed
+    const filesAfter = await fs.promises.readdir(runnerTemp)
+    const credentialsFilesAfter = filesAfter.filter(
+      f => f.startsWith('git-credentials-') && f.endsWith('.config')
+    )
+    expect(credentialsFilesAfter.length).toBe(0)
+
+    // Verify includeIf entries pointing to our specific credentials file were removed
+    const includeIfKeysAfter = await git.tryGetConfigKeys(
+      '^includeIf\\.gitdir:'
+    )
+    let credentialIncludesForThisActionAfter = 0
+    for (const key of includeIfKeysAfter) {
+      const values = await git.tryGetConfigValues(key)
+      for (const value of values) {
+        if (value === credentialsPath) {
+          credentialIncludesForThisActionAfter++
+        }
+      }
+    }
+    expect(credentialIncludesForThisActionAfter).toBe(0)
   })
 
-  it('tests save and restore of persisted auth', async () => {
+  it('tests save and restore of persisted auth (old-style)', async () => {
     const extraheaderConfigValue = 'AUTHORIZATION: basic ***persisted-auth***'
     await git.config(extraheaderConfigKey, extraheaderConfigValue)