Skip to content

fix: complete write schema reference and add structural checks to review#794

Merged
FL4TLiN3 merged 1 commit intomainfrom
fix/write-schema-and-review-structural-checks
Mar 14, 2026
Merged

fix: complete write schema reference and add structural checks to review#794
FL4TLiN3 merged 1 commit intomainfrom
fix/write-schema-and-review-structural-checks

Conversation

@FL4TLiN3
Copy link
Contributor

Summary

  • write schema: List valid defaultModelTier values ("low", "middle", "high"), valid tool names for pick (full list), allowed fields per expert (reject unknown fields like instructionFile)
  • write instruction quality: Add guidance — instructions contain domain constraints only, not implementation procedures, command flags, exit codes, file paths, or schemas
  • review structural checks: New checklist section verifying valid field names, tool names, modelTier values, required fields, delegates array presence
  • Bump to 1.0.25

Context

Generated perstack.toml had readFile (invalid), "mid" (invalid), instructionFile = true (non-existent field), and massive procedural instructions. Write didn't know the valid values, review didn't check for them.

Test plan

  • Run create-expert and verify generated perstack.toml uses correct tool names
  • Confirm defaultModelTier uses "low"/"middle"/"high" only
  • Verify review catches invalid tool names and unknown fields
  • Check instructions are concise domain constraints, not procedures

🤖 Generated with Claude Code

Write was producing invalid tool names (readFile), invalid modelTier (mid),
and unknown fields (instructionFile) because the schema didn't specify valid
values. Review wasn't catching these because its checklist only covered
instruction content quality, not structural correctness.

Changes:
- write: schema lists valid defaultModelTier values, valid tool names for
  pick, and allowed fields per expert. Add instruction quality guidance
  (domain constraints only, no implementation procedures).
- review: add structural correctness section to checklist (valid field
  names, valid tool names, valid modelTier values, required fields).
- Bump to 1.0.25.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@FL4TLiN3 FL4TLiN3 merged commit 601cf11 into main Mar 14, 2026
11 checks passed
@FL4TLiN3 FL4TLiN3 deleted the fix/write-schema-and-review-structural-checks branch March 14, 2026 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant