Skip to content

[BUGFIX] Loki query migration incorrectly matching non-Loki datasources #682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gfierkasap wants to merge 6 commits into
base: main
Choose a base branch
from
Open

[BUGFIX] Loki query migration incorrectly matching non-Loki datasources #682

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d58d9d9
changed the loki log query migration condition
gfierkasap Jun 16, 2026
291e0e2
fixed linting
gfierkasap Jun 16, 2026
194bf30
Merge branch 'main' into issue-4134-migration-bug
gfierkasap Jun 16, 2026
83933e0
re-added ... in loki log query migrate
gfierkasap Jun 17, 2026
e33808c
merge main
gfierkasap Jun 17, 2026
c811fde
added stricter type and uid
gfierkasap Jun 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions loki/schemas/queries/loki-log-query/migrate/migrate.cue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,20 +15,23 @@ package migrate

#target: {
datasource: {
type: "loki"
type?: "loki"
uid: string
...
}
Comment on lines 17 to 21

@gfierkasap gfierkasap Jun 17, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

83933e0

Comment on lines 17 to 21
expr: string
...
}

kind: "LokiLogQuery"
spec: {
if #target.datasource.uid != _|_ {
datasource: {
kind: "LokiDatasource"
name: #target.datasource.uid
if #target.datasource.type != _|_ if #target.datasource.type == "loki" {
kind: "LokiLogQuery"
Comment on lines +26 to +27
spec: {
if #target.datasource.uid != _|_ {
datasource: {
kind: "LokiDatasource"
name: #target.datasource.uid
}
}
query: #target.expr
}
query: #target.expr
}
Loading