fix: use uppercase Bearer in Authorization headers #123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Cloud PDP requires uppercase "Bearer" in the Authorization header per RFC 6750. Using lowercase "bearer" causes 401 Unauthorized errors. Fixes permitio#122
There was a problem hiding this comment.
Pull request overview
This PR fixes Authorization header formatting to comply with RFC 6750 by changing "bearer" to "Bearer" (uppercase). The Cloud PDP was rejecting requests with lowercase "bearer" and returning 401 Unauthorized errors.
- Changed Authorization header format from
f"bearer {token}"tof"Bearer {token}"across all API client implementations
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| permit/pdp_api/pdp_api_client.py | Updated Authorization header to use uppercase "Bearer" in PDP API client initialization |
| permit/pdp_api/base.py | Updated Authorization header to use uppercase "Bearer" in HTTP client builder |
| permit/enforcement/enforcer.py | Updated Authorization header to use uppercase "Bearer" in enforcer initialization |
| permit/api/base.py | Updated Authorization header to use uppercase "Bearer" in API base HTTP client builder |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The Cloud PDP requires uppercase "Bearer" in the Authorization header per RFC 6750. Using lowercase "bearer" causes 401 Unauthorized errors.
Changes
Fixed 4 files:
permit/enforcement/enforcer.py:47permit/api/base.py:177permit/pdp_api/base.py:51permit/pdp_api/pdp_api_client.py:22Testing
bearerBearerFixes #122