Repository navigation
Fix implicit null issues for php 8.4 - #40
Merged
patinthehat merged 5 commits intoOct 29, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #40 +/- ##
=========================================
Coverage 82.53% 82.53%
Complexity 225 225
=========================================
Files 49 49
Lines 618 618
=========================================
Hits 510 510
Misses 108 108
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
… versions 7.4 and <= 8.3 therefore we should omit the comparisons till we remove support for these older versions
Member
|
Apologies for the delay merging. Thank you! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update previously common "implicit" nullable method inputs that are now deprecated in PHP 8.4 and future versions.
These changes maintain PHP 7.4 support for the time being, but as versions prior to 8.2 are now EoL, support for them should be removed at a later stage.
The snapshot tests were failing on main as well as here: they serialise result objects with symfony/serializer, and composer picks a different serializer major per PHP version (5.4 on 7.4, 6.x on 8.0/8.1, 7.x/8.x on 8.2+). Each one orders properties differently and newer ones include the protected
$file. symfony/serializer, property-access and property-info are now pinned to ^5.4 in require-dev, which works on every PHP version from 7.4 to 8.5, so every job serialises the same way. One snapshot is re-recorded for thepartialFunctionApplicationfield nikic/php-parser 5.9 added. The full suite now runs on 7.4, 8.0, 8.1, 8.2, 8.3, 8.4 and 8.5.